linux-kernel - Re: [PATCH] gnss: fix potential error pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180703121143.GP9802@localhost>
Date:   Tue, 3 Jul 2018 14:11:43 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Johan Hovold <johan@...nel.org>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] gnss: fix potential error pointer dereference

On Tue, Jul 03, 2018 at 02:59:22PM +0300, Dan Carpenter wrote:
> The gnss_allocate_device() function returns a mix of NULL and error
> pointers on error.  It should only return one or the other.  Since the
> callers both check for NULL, I've modified it to return NULL on error.
> 
> Fixes: 10f146639fee ("gnss: add receiver type support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Ouch, thanks for catching this!

I think you got the wrong commit for the fixes tag above, however. That
should be:

Fixes: 2b6a44035143 ("gnss: add GNSS receiver subsystem")

Not sure if you want to send a v2, or if Greg can fix that when
applying. Apart from that:

Acked-by: Johan Hovold <johan@...nel.org>

Johan