linux-kernel - Re: [PATCH] gnss: fix potential error pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180703122309.x6m4hrawpg2tb2bu@mwanda>
Date:   Tue, 3 Jul 2018 15:23:09 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] gnss: fix potential error pointer dereference

On Tue, Jul 03, 2018 at 02:11:43PM +0200, Johan Hovold wrote:
> On Tue, Jul 03, 2018 at 02:59:22PM +0300, Dan Carpenter wrote:
> > The gnss_allocate_device() function returns a mix of NULL and error
> > pointers on error.  It should only return one or the other.  Since the
> > callers both check for NULL, I've modified it to return NULL on error.
> > 
> > Fixes: 10f146639fee ("gnss: add receiver type support")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> Ouch, thanks for catching this!
> 
> I think you got the wrong commit for the fixes tag above, however. That
> should be:
> 
> Fixes: 2b6a44035143 ("gnss: add GNSS receiver subsystem")
> 

Oops.  That's what I intended, yes.  I will resend.

regards,
dan carpenter