linux-kernel - Re: [BUG] Caused by: sched/deadline: Move CPU frequency selection triggering points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180703114915.510f959c@gandalf.local.home>
Date:   Tue, 3 Jul 2018 11:49:15 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Juri Lelli <juri.lelli@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Claudio Scordino <claudio@...dence.eu.com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Clark Williams <williams@...hat.com>
Subject: Re: [BUG] Caused by: sched/deadline: Move CPU frequency selection
 triggering points

On Tue, 3 Jul 2018 11:31:20 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue, 3 Jul 2018 17:07:11 +0200
> Juri Lelli <juri.lelli@...hat.com> wrote:
> 
> > This got into tip quite recently
> > 
> > ecda2b66e263 ("sched/deadline: Fix missing clock update")
> > 
> > could you please double check that you have that in your stack?
> >   
> 
> Unfortunately, I just tested it out, and it still locks up with this
> patch.
> 

It appears that the below patch fixes the issue for me.

Is this a correct usage?

-- Steve

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index fbfc3f1d368a..90b6e9df79b2 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -2085,6 +2085,8 @@ static int push_dl_task(struct rq *rq)
 		goto retry;
 	}
 
+	update_rq_clock(later_rq);
+
 	deactivate_task(rq, next_task, 0);
 	sub_running_bw(&next_task->dl, &rq->dl);
 	sub_rq_bw(&next_task->dl, &rq->dl);