linux-kernel - Re: [PATCH 0/2] tools/memory-model: remove ACCESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180703155303.GA3593@linux.vnet.ibm.com>
Date:   Tue, 3 Jul 2018 08:53:03 -0700
From:   "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:     Andrea Parri <andrea.parri@...rulasolutions.com>
Cc:     Mark Rutland <mark.rutland@....com>, linux-kernel@...r.kernel.org,
        akiyks@...il.com, boqun.feng@...il.com, dhowells@...hat.com,
        j.alglave@....ac.uk, luc.maranget@...ia.fr, npiggin@...il.com,
        peterz@...radead.org, stern@...land.harvard.edu,
        will.deacon@....com, davem@...emloft.net
Subject: Re: [PATCH 0/2] tools/memory-model: remove ACCESS_ONCE()

On Tue, Jul 03, 2018 at 12:12:41PM +0200, Andrea Parri wrote:
> > >   1) Merge the file touched by that patch into (the recently created):
> > >   
> > >         Documentation/atomic_t.txt
> > > 
> > >      (FWIW, queued in my TODO list).
> > 
> > Some consolidation of documentation would be good.  ;-)
> > 
> > Thoughts from others?
> > 
> > >   2) Add the entry:
> > > 
> > > 	F: Documentation/atomic_t.txt
> > > 
> > >      to the "ATOMIC INFRASTRUCTURE" subsystem in the MAINTAINERS file so
> > >      that developers can easily find (the intended?) reviewers for their
> > >      patch. (Of course, this will need ACK from the ATOMIC people).
> > 
> > If the merging will take awhile, it might also be good to put
> > Documentation/core-api/atomic_ops.rst somewhere as well.
> 
> Indeed.  And let's not forget the "orphaned":
> 
>   Documentation/atomic_bitops.txt
>   Documentation/core-api/refcount-vs-atomic.rst

Lots of puppies to adopt, aren't there?  ;-)

I could make the argument that these files are part of the documentation
for the Linux kernel's memory model, and that they should therefore be
added to the LKMM MAINTAINERS entry.  Any objections?  (Adding David
Miller in his capacity of author of atomic_ops.txt.)

Separately, it might be good to make sure that the linux-arch folks are
aware of proposed changes to the memory model.  To that end, would it
make sense to add the linux-arch mailing list to that same entry?

							Thanx, Paul

------------------------------------------------------------------------

commit 33a58ee5eadadfb1f4850eabd4fac332984881d5
Author: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
Date:   Tue Jul 3 08:48:09 2018 -0700

    tools/memory-model: Add informal LKMM documentation to MAINTAINERS
    
    The Linux-kernel memory model has been informal, with a number of
    text files documenting it.  It would be good to make sure that these
    informal descriptions are kept up to date and/or pruned appropriately.
    This commit therefore brings more of those text files into the LKMM
    MAINTAINERS file entry.
    
    Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
    Cc: Alan Stern <stern@...land.harvard.edu>
    Cc: Andrea Parri <andrea.parri@...rulasolutions.com>
    Cc: Will Deacon <will.deacon@....com>
    Cc: Peter Zijlstra <peterz@...radead.org>
    Cc: Boqun Feng <boqun.feng@...il.com>
    Cc: Nicholas Piggin <npiggin@...il.com>
    Cc: David Howells <dhowells@...hat.com>
    Cc: Jade Alglave <j.alglave@....ac.uk>
    Cc: Luc Maranget <luc.maranget@...ia.fr>
    Cc: Akira Yokosawa <akiyks@...il.com>
    Cc: Daniel Lustig <dlustig@...dia.com>
    Cc: "David S. Miller" <davem@...emloft.net>

diff --git a/MAINTAINERS b/MAINTAINERS
index f2903b818671..2ba947fc9a2f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8321,6 +8321,10 @@ L:	linux-kernel@...r.kernel.org
 S:	Supported
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
 F:	tools/memory-model/
+F:	Documentation/atomic_bitops.txt
+F:	Documentation/atomic_t.txt
+F:	Documentation/core-api/atomic_ops.rst
+F:	Documentation/core-api/refcount-vs-atomic.rst
 F:	Documentation/memory-barriers.txt
 
 LINUX SECURITY MODULE (LSM) FRAMEWORK