linux-kernel - Re: [PATCH 1/2] Revert "mfd: cros_ec: Remove unused _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180704064811.GD20176@dell>
Date:   Wed, 4 Jul 2018 07:48:11 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        Gwendal Grignou <gwendal@...omium.org>,
        Benson Leung <bleung@...omium.org>
Subject: Re: [PATCH 1/2] Revert "mfd: cros_ec: Remove unused __remove
 function"

On Wed, 20 Jun 2018, Dmitry Torokhov wrote:

> This reverts commit 556c242045f0c1613aac2e64dc5b2ff0e4bc89e1.
> 
> The patch that this change is purported to fix is broken and should be
> reverted; thus we reverting this one as well.

You need to provide more information.

How does the original patch break the build/code execution?
What is this patch doing to rectify the issue?
Any other information you think is relevant.

> ---
> 
> Lee,
> 
> I see the broken code is already in Linus' tree, so please merge send
> it on at your earliest convenience.
> 
> Thanks,
> Dmitry
> 
> 
>  drivers/mfd/cros_ec_dev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index 306e1fd109bd..4b1dbe81fcb6 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -262,6 +262,8 @@ static const struct file_operations fops = {
>  #endif
>  };
>  
> +static void __remove(struct device *dev) { }
> +
>  static void cros_ec_sensors_register(struct cros_ec_dev *ec)
>  {
>  	/*

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog