linux-kernel - Re: [PATCH 2/2] Revert "mfd: cros_ec: Use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180704070008.GE20176@dell>
Date:   Wed, 4 Jul 2018 08:00:08 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        Gwendal Grignou <gwendal@...omium.org>,
        Benson Leung <bleung@...omium.org>
Subject: Re: [PATCH 2/2] Revert "mfd: cros_ec: Use devm_kzalloc for private
 data"

On Wed, 20 Jun 2018, Dmitry Torokhov wrote:

> This reverts commit 3aa2177e47878f7e7616da8a2050c44f22301b6e.
> 
> Linux device objects are refcounted and thus should not be allocated
> with devm API as they may outlive the timeframe of another device being
> bound to a driver.
> ---
>  drivers/mfd/cros_ec_dev.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog