linux-kernel - Re: [PATCH 1/2] Revert "mfd: cros_ec: Remove unused _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180704151622.sncbvlrlv3tuilrp@penguin>
Date:   Wed, 4 Jul 2018 15:16:22 +0000
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        Gwendal Grignou <gwendal@...omium.org>,
        Benson Leung <bleung@...omium.org>
Subject: Re: [PATCH 1/2] Revert "mfd: cros_ec: Remove unused __remove
 function"

Hi Lee,

On Wed, Jul 04, 2018 at 07:48:11AM +0100, Lee Jones wrote:
> On Wed, 20 Jun 2018, Dmitry Torokhov wrote:
> 
> > This reverts commit 556c242045f0c1613aac2e64dc5b2ff0e4bc89e1.
> > 
> > The patch that this change is purported to fix is broken and should be
> > reverted; thus we reverting this one as well.
> 
> You need to provide more information.
> 
> How does the original patch break the build/code execution?
> What is this patch doing to rectify the issue?
> Any other information you think is relevant.

We are reverting this patch because it is not needed: it tries to fix
another patch that is completely broken and needs to be reverted. The
justification for reverting the original broken patch is in the revert
of that patch, but just for reference:

We should not use devm_kzalloc() to allocate refcounted objects.

Thanks.

-- 
Dmitry