linux-kernel - Re: [PATCH 01/15] Introduce Cadence USBSSP DRD Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180704091342.GA25518@kroah.com>
Date:   Wed, 4 Jul 2018 11:13:42 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pawel Laszczak <pawell@...ence.com>
Cc:     linux-usb@...r.kernel.org, Felipe Balbi <balbi@...nel.org>,
        linux-kernel@...r.kernel.org, ltyrala@...ence.com
Subject: Re: [PATCH 01/15] Introduce Cadence USBSSP DRD Driver - added
 gadget.c file.

On Tue, Jul 03, 2018 at 08:57:45PM +0100, Pawel Laszczak wrote:
> From: Laszczak Pawel <pawell.cadence.com>
> 
> Signed-off-by: Laszczak Pawel <pawell@...ence.com>
> ---

I can't take patches without any changelog text at all, sorry.

Also, your subject lines need work, look at how all other usb patches
are written, your long prefix is not really helping out here.

>  drivers/usb/usbssp/gadget.c | 2082 +++++++++++++++++++++++++++++++++++
>  1 file changed, 2082 insertions(+)
>  create mode 100644 drivers/usb/usbssp/gadget.c

Just splitting the driver up by file is hard to review, as you are just
dumping individual files on us, not functionality, and we can not review
anything until all of them are added.  Can you break this up into
logical chunks?  Make these in a way that is easy to review, would you
want to review this patch series in this way?

thanks,

greg k-h