linux-kernel - Re: [PATCH 09/15] Introduce Cadence USBSSP DRD Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180704091524.GB25518@kroah.com>
Date:   Wed, 4 Jul 2018 11:15:24 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pawel Laszczak <pawell@...ence.com>
Cc:     linux-usb@...r.kernel.org, Felipe Balbi <balbi@...nel.org>,
        linux-kernel@...r.kernel.org, ltyrala@...ence.com
Subject: Re: [PATCH 09/15] Introduce Cadence USBSSP DRD Driver - added
 debugfs files.

On Tue, Jul 03, 2018 at 08:57:53PM +0100, Pawel Laszczak wrote:
> Signed-off-by: Laszczak Pawel <pawell@...ence.com>
> ---

Again for all of these, you need a changelog text.

>  drivers/usb/usbssp/gadget-debugfs.c | 514 ++++++++++++++++++++++++++++
>  drivers/usb/usbssp/gadget-debugfs.h | 137 ++++++++
>  2 files changed, 651 insertions(+)
>  create mode 100644 drivers/usb/usbssp/gadget-debugfs.c
>  create mode 100644 drivers/usb/usbssp/gadget-debugfs.h
> 
> diff --git a/drivers/usb/usbssp/gadget-debugfs.c b/drivers/usb/usbssp/gadget-debugfs.c
> new file mode 100644
> index 000000000000..c0d1e96728e6
> --- /dev/null
> +++ b/drivers/usb/usbssp/gadget-debugfs.c
> @@ -0,0 +1,514 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * USBSSP device controller driver
> + *
> + * Copyright (C) 2018 Cadence.
> + *
> + * Author: Pawel Laszczak
> + * Some code borrowed from the Linux XHCI driver.

What code was borrowed?  Please acknowledge that copyright.

Also, why isn't Pawel's signed-off-by on this?

thanks,

greg k-h