linux-kernel - Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180705114600.f27xfsro3yucorrt@mwanda>
Date:   Thu, 5 Jul 2018 14:46:00 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Tamir Suliman <tsuliman@...uxvaults.com>
Cc:     Justin Skists <justin.skists@...za.co.uk>, w.d.hubbs@...il.com,
        gregkh@...uxfoundation.org, speakup@...ux-speakup.org,
        devel@...verdev.osuosl.org, dhowells@...hat.com,
        linux-kernel@...r.kernel.org, chris@...-brannons.com
Subject: Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings



On Wed, Jul 04, 2018 at 10:46:05PM +0300, Tamir Suliman wrote:
> 
> Interesting construct...  Yeah I'm little bit rusty on my C /programming  .
> I understand  proper coding style may be should end with else so I wasn't
> sure .. however this resolved the warnings. :)


The code you wrote was very wrong.

It doesn't compile.  You need to figure out what is wrong with your
testing so that it doesn't happen again.

regards,
dan carpenter