[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180705115549.wifgpi5qe6dfkcoj@mwanda>
Date: Thu, 5 Jul 2018 14:55:49 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Justin Skists <justin.skists@...za.co.uk>
Cc: w.d.hubbs@...il.com, gregkh@...uxfoundation.org,
speakup@...ux-speakup.org,
Tamir Suliman <tsuliman@...uxvaults.com>,
devel@...verdev.osuosl.org, dhowells@...hat.com,
linux-kernel@...r.kernel.org, chris@...-brannons.com
Subject: Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings
On Tue, Jul 03, 2018 at 09:10:55AM +0100, Justin Skists wrote:
> > @@ -787,7 +787,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,
> > continue;
> > }
> >
> > - index = simple_strtoul(cp, &temp, 10);
> > + index = simple_ktrtoul(cp, &temp, 10);
>
> Did you compile this?
Try to avoid rhetorical questions. Just say "This doesn't compile. Be
more careful."
regards,
dan carpenter
Powered by blists - more mailing lists