linux-kernel - Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Jul 2018 14:55:49 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Justin Skists <justin.skists@...za.co.uk>
Cc:     w.d.hubbs@...il.com, gregkh@...uxfoundation.org,
        speakup@...ux-speakup.org,
        Tamir Suliman <tsuliman@...uxvaults.com>,
        devel@...verdev.osuosl.org, dhowells@...hat.com,
        linux-kernel@...r.kernel.org, chris@...-brannons.com
Subject: Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings

On Tue, Jul 03, 2018 at 09:10:55AM +0100, Justin Skists wrote:
> > @@ -787,7 +787,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,
> >  			continue;
> >  		}
> >  
> > -		index = simple_strtoul(cp, &temp, 10);
> > +		index = simple_ktrtoul(cp, &temp, 10);
> 
> Did you compile this?

Try to avoid rhetorical questions.  Just say "This doesn't compile.  Be
more careful."

regards,
dan carpenter