linux-kernel - Re: [PATCH v2 3/4] RISC-V: Add definiion of extract symbol's index and type for 32-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+ZOyaggr-Y2-Yh_o4+XQLoT5-o6PM9m4_T3sHHUq13+CgJYEQ@mail.gmail.com>
Date:   Thu, 5 Jul 2018 21:33:07 +0800
From:   Zong Li <zongbox@...il.com>
To:     Palmer Dabbelt <palmer@...ive.com>
Cc:     hch@...radead.org, Zong Li <zong@...estech.com>,
        linux-riscv@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        greentime@...estech.com
Subject: Re: [PATCH v2 3/4] RISC-V: Add definiion of extract symbol's index
 and type for 32-bit

Palmer Dabbelt <palmer@...ive.com> 於 2018年7月5日 週四 上午4:58寫道：
>
> On Fri, 29 Jun 2018 09:53:49 PDT (-0700), zongbox@...il.com wrote:
> > Christoph Hellwig <hch@...radead.org> 於 2018年6月29日 週五 下午3:12寫道：
> >>
> >> On Mon, Jun 25, 2018 at 04:49:39PM +0800, Zong Li wrote:
> >> > Use generic marco to get the index and type of symbol.
> >>
> >> Why do we even need this in a uapi header?  Shouldn't ELF_RISCV_R_SYM
> >> and ELF_RISCV_R_TYPE move to module.c?  In that case we could just
> >> use CONFIG_64BIT.
> >
> > Make sense. I even think the all definitions can be move to include/asm/elf.h.
> > How do you think about that?
>
> Sorry I've been slow about reviewing this, but I think just in the interest of
> getting a sane RV32I port up and running quickly (so we can try to get glibc in
> shape) I'm going to take this for now.
>
> Do you mind submitting a cleanup patch?

I will send a patch to clean up. Thanks everyone to review this patchset.