linux-kernel - Re: [PATCH 09/15] Introduce Cadence USBSSP DRD Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180705151319.GB10795@kroah.com>
Date:   Thu, 5 Jul 2018 17:13:19 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pawel Laszczak <pawell@...ence.com>
Cc:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Felipe Balbi <balbi@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Lukasz Tyrala <ltyrala@...ence.com>,
        Bartosz Folta <bfolta@...ence.com>
Subject: Re: [PATCH 09/15] Introduce Cadence USBSSP DRD Driver - added
 debugfs files.

On Thu, Jul 05, 2018 at 09:44:27AM +0000, Pawel Laszczak wrote:
> > > Signed-off-by: Laszczak Pawel <pawell@...ence.com>
> > > ---
> > 
> > Again for all of these, you need a changelog text.
> > 
> > >  drivers/usb/usbssp/gadget-debugfs.c | 514
> > ++++++++++++++++++++++++++++
> > >  drivers/usb/usbssp/gadget-debugfs.h | 137 ++++++++
> > >  2 files changed, 651 insertions(+)
> > >  create mode 100644 drivers/usb/usbssp/gadget-debugfs.c
> > >  create mode 100644 drivers/usb/usbssp/gadget-debugfs.h
> > >
> > > diff --git a/drivers/usb/usbssp/gadget-debugfs.c
> > b/drivers/usb/usbssp/gadget-debugfs.c
> > > new file mode 100644
> > > index 000000000000..c0d1e96728e6
> > > --- /dev/null
> > > +++ b/drivers/usb/usbssp/gadget-debugfs.c
> > > @@ -0,0 +1,514 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * USBSSP device controller driver
> > > + *
> > > + * Copyright (C) 2018 Cadence.
> > > + *
> > > + * Author: Pawel Laszczak
> > > + * Some code borrowed from the Linux XHCI driver.
> > 
> > What code was borrowed?  Please acknowledge that copyright.
> 
> USBSSP controller is very similar to XHCI controller and 
> is mostly  compliance with XHCI specification.  
> In result, driver for device mode based on 
> drivers/usb/host/xhci* driver. 
> 
> Especially xhci.c, xhci-ring.c, xhci-mem.c , xhci-debugfs.c
> and xhci-trace.h was re-used. By borrowed I means that these 
> files have been taken from xhci driver and have been adopted
> in such way that it can be use for the device side. 
> Probably this sentence should looks like: 
> " A  lot of code based on Linux XHCI driver" ?

Be specific, just like you said so here.  And include the copyright
ownership of that code please, because it is relevant here.

> You know, the most of algorithm for handling transfer and
> memory management are the same as for XHCI driver.
> 
> Because the USB gadget API in kernel completely different 
> from Host USB API, so files had to been changed very much. 
> 
> What do you think by "Please acknowledge that copyright" ?
> 
> "
> The standard header for xhci driver looks like: 
> // SPDX-License-Identifier: GPL-2.0
> /*
>  * xHCI host controller driver PCI Bus Glue.
>  *
>  * Copyright (C) 2008 Intel Corp.
>  *
>  * Author: Sarah Sharp
>  * Some code borrowed from the Linux EHCI driver.
>  */
> "
> Should I add In my header:
> Copyright (C) 2018 Cadence. 
> Copyright (C) 2008 Intel Corp.
> 
> or something like this:
> .... 
> A  lot of code based on Linux XHCI driver
> Origin: Copyright (C) 2008 Intel Corp

Yes, that would be good.

thanks,

greg k-h