linux-kernel - Re: [PATCH 01/15] Introduce Cadence USBSSP DRD Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180705151417.GC10795@kroah.com>
Date:   Thu, 5 Jul 2018 17:14:17 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pawel Laszczak <pawell@...ence.com>
Cc:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Felipe Balbi <balbi@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Lukasz Tyrala <ltyrala@...ence.com>,
        Bartosz Folta <bfolta@...ence.com>
Subject: Re: [PATCH 01/15] Introduce Cadence USBSSP DRD Driver - added
 gadget.c file.

On Thu, Jul 05, 2018 at 10:15:04AM +0000, Pawel Laszczak wrote:
> > On Tue, Jul 03, 2018 at 08:57:45PM +0100, Pawel Laszczak wrote:
> > > From: Laszczak Pawel <pawell.cadence.com>
> > >
> > > Signed-off-by: Laszczak Pawel <pawell@...ence.com>
> > > ---
> > 
> > I can't take patches without any changelog text at all, sorry.
> > 
> > Also, your subject lines need work, look at how all other usb patches are
> > written, your long prefix is not really helping out here.
> > 
> > >  drivers/usb/usbssp/gadget.c | 2082
> > > +++++++++++++++++++++++++++++++++++
> > >  1 file changed, 2082 insertions(+)
> > >  create mode 100644 drivers/usb/usbssp/gadget.c
> > 
> > 
> > Just splitting the driver up by file is hard to review, as you are just dumping
> > individual files on us, not functionality, and we can not review anything until
> > all of them are added.  Can you break this up into logical chunks?  Make
> > these in a way that is easy to review, would you want to review this patch
> > series in this way?
> 
> It's quite large driver and I thought that this form will be better and faster to review. 

How can you review it file-by-file without seeing how they all interact?

> I didn't want to prepare too much patches.

Yes, it is more work, but that is how we do kernel development as you
want us to review the code.  Just think about what you would want if you
had to review all of this.

thanks,

greg k-h