[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1a4d5505-2359-9c50-3e90-58336592bb52@intel.com>
Date: Thu, 5 Jul 2018 09:09:24 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc: x86@...nel.org, platform-driver-x86@...r.kernel.org,
sean.j.christopherson@...el.com, nhorman@...hat.com,
npmccallum@...hat.com, linux-sgx@...r.kernel.org,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>,
Tom Lendacky <thomas.lendacky@....com>,
Borislav Petkov <bp@...e.de>,
Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Janakarajan Natarajan <Janakarajan.Natarajan@....com>,
David Woodhouse <dwmw@...zon.co.uk>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v12 03/13] x86/sgx: add SGX definitions to msr-index.h
On 07/05/2018 09:05 AM, Jarkko Sakkinen wrote:
> On Tue, Jul 03, 2018 at 11:31:59AM -0700, Dave Hansen wrote:
>> On 07/03/2018 11:19 AM, Jarkko Sakkinen wrote:
>>> --- a/arch/x86/include/asm/msr-index.h
>>> +++ b/arch/x86/include/asm/msr-index.h
>>> @@ -479,6 +479,8 @@
>>> #define FEATURE_CONTROL_LOCKED (1<<0)
>>> #define FEATURE_CONTROL_VMXON_ENABLED_INSIDE_SMX (1<<1)
>>> #define FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX (1<<2)
>>> +#define FEATURE_CONTROL_SGX_ENABLE (1<<18)
>>> +#define FEATURE_CONTROL_SGX_LE_WR (1<<17)
>>> #define FEATURE_CONTROL_LMCE (1<<20)
>> Have you run checkpatch.pl on these? There's a tabs-vs-spaces issue here.
> High portion of lines in this file are over 80 characters and have this
> same incosistent spacing. I'm not sure if this should be fixed bacause
> it would be consistent with the formatting that this file uses...
Why does that matter?
Just make sure your patch doesn't introduce any new instances of bad
form unless it's *required* to fit into the file.
Powered by blists - more mailing lists