linux-kernel - Re: [PATCH 1/4] scsi: aacraid: remove AAC_STAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <babfea1746aaca57109f84bff674dda635a76e29.camel@wdc.com>
Date:   Thu, 5 Jul 2018 17:24:23 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "jthumshirn@...e.de" <jthumshirn@...e.de>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "RaghavaAditya.Renukunta@...rosemi.com" 
        <RaghavaAditya.Renukunta@...rosemi.com>,
        "david.carroll@...rosemi.com" <david.carroll@...rosemi.com>
Subject: Re: [PATCH 1/4] scsi: aacraid: remove AAC_STAT_GOOD define

On Thu, 2018-07-05 at 13:01 +0200, Johannes Thumshirn wrote:
>  		if (((aac_cache & 6) == 6) && dev->cache_protected) {
> -			scsicmd->result = AAC_STAT_GOOD;
> +			scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8 |
> +					  SAM_STAT_GOOD;

Does AAC_STAT_GOOD really have to be expanded in full multiple times?
Have you considered to replace AAC_STAT_GOOD by the numerical constant
0 instead?

Thanks,

Bart.