linux-kernel - Re: [PATCH v7 02/16] leds: triggers: let struct led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1172a776-a951-28d5-fae4-824969f4a82b@gmail.com>
Date:   Thu, 5 Jul 2018 23:31:28 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     Pavel Machek <pavel@....cz>, kernel@...gutronix.de,
        linux-leds@...r.kernel.org, kernel-patch-test@...ts.linaro.org,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Johannes Berg <johannes@...solutions.net>,
        linux-bluetooth@...r.kernel.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 02/16] leds: triggers: let struct
 led_trigger::activate() return an error code

Hi Uwe,

On 07/02/2018 10:05 PM, Uwe Kleine-König wrote:
> Given that activating a trigger can fail, let the callback return an
> indication. This prevents to have a trigger active according to the
> "trigger" sysfs attribute but not functional.
> 
> All users are changed accordingly to return 0 for now. There is no intended
> change in behaviour.
> 
> Acked-by: Pavel Machek <pavel@....cz>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
[...]
> -static void ieee80211_tx_led_activate(struct led_classdev *led_cdev)
> +static int ieee80211_tx_led_activate(struct led_classdev *led_cdev)
>   {
>   	struct ieee80211_local *local = container_of(led_cdev->trigger,
>   						     struct ieee80211_local,
>   						     tx_led);
>   
>   	atomic_inc(&local->tx_led_active);
> +
> +	return 0
[...]

s/return 0/return 0;/

Fixed it up and applied. I'm taking lack of net maintainer feedback
as a tacit approval (or lack of interest).

-- 
Best regards,
Jacek Anaszewski