linux-kernel - Re: [PATCH v4 3/3] iio: hx711: warning in dt binding example doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180705213237.GA22282@rob-hp-laptop>
Date:   Thu, 5 Jul 2018 15:32:37 -0600
From:   Rob Herring <robh@...nel.org>
To:     Andreas Klinger <ak@...klinger.de>
Cc:     jic23@...nel.org, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, mark.rutland@....com, mchehab@...nel.org,
        davem@...emloft.net, gregkh@...uxfoundation.org,
        akpm@...ux-foundation.org, linus.walleij@...aro.org,
        rdunlap@...radead.org, devicetree@...r.kernel.org,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/3] iio: hx711: warning in dt binding example doc

On Wed, Jul 04, 2018 at 02:37:19PM +0200, Andreas Klinger wrote:
> device tree compiler (dtc) gives a warning if a device node has "@" with a
> following number as it's name but no reg property.
> 
> fix the example in the documentation of avia,hx711 to conform to dtc
> behavior

Capitalization and punctuation needed.

The subject could be more specific. Perhaps "... fix spurious 
unit-address in example"

> 
> Signed-off-by: Andreas Klinger <ak@...klinger.de>
> ---
>  Documentation/devicetree/bindings/iio/adc/avia-hx711.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> index 4bee51d536e1..b218e093b55a 100644
> --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt
> @@ -18,7 +18,7 @@ Optional properties:
>  			high time of 50 microseconds.
>  
>  Example:
> -weight@0 {
> +weight {
>  	compatible = "avia,hx711";
>  	sck-gpios = <&gpio3 10 GPIO_ACTIVE_HIGH>;
>  	dout-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>;
> -- 
> 2.1.4