linux-kernel - Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.21.1807051623400.12206@localhost.localdomain>
Date:   Thu, 5 Jul 2018 16:24:16 -0400 (EDT)
From:   "Robert P. J. Day" <rpjday@...shcourse.ca>
To:     Rob Herring <robh@...nel.org>
cc:     alanx.chiang@...el.com, linux-i2c@...r.kernel.org,
        andy.yeh@...el.com, sakari.ailus@...ux.intel.com,
        andriy.shevchenko@...ux.intel.com, andriy.shevchenko@...el.com,
        rajmohan.mani@...el.com, andy.shevchenko@...il.com,
        tfiga@...omium.org, jcliang@...omium.org, brgl@...ev.pl,
        mark.rutland@....com, arnd@...db.de, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width
 property

On Thu, 5 Jul 2018, Rob Herring wrote:

> On Mon, Jul 02, 2018 at 05:12:19PM +0800, alanx.chiang@...el.com wrote:
> > From: Alan Chiang <alanx.chiang@...el.com>
> >
> > The AT24 series chips use 8-bit address by default. If some
> > chips would like to support more than 8 bits, the at24 driver
> > should be added the compatible field for specfic chips.
> >
> > Provide a flexible way to determine the addressing bits through
> > address-width in this patch.
> >
> > Signed-off-by: Alan Chiang <alanx.chiang@...el.com>
> > Signed-off-by: Andy Yeh <andy.yeh@...el.com>
> > Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> >
> > ---
> > since v1:
> > -- Remove the address-width field in the example.
> > since v2:
> > -- Remove redundant space.
> > since v3:
> > -- Add Acked-by.
> >
> > ---
> >  Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
> >  1 file changed, 2 insertions(+)
>
> Reviewed-by: Rob Herring <robh@...nel.org>

  "... should be added the compatible field ..."??

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                  http://crashcourse.ca/dokuwiki

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================