linux-kernel - Re: [PATCH] drm/stm: ltdc: rework reset sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+M3ks5GNf6i_mFqFEganGJ7-3nY+OxGwxzX1UYbT1dkv8WtMg@mail.gmail.com>
Date:   Fri, 6 Jul 2018 10:22:43 +0200
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Yannick Fertre <yannick.fertre@...com>
Cc:     Philippe Cornu <philippe.cornu@...com>,
        Vincent Abriou <vincent.abriou@...com>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/stm: ltdc: rework reset sequence

2018-06-29 13:22 GMT+02:00 Yannick Fertre <yannick.fertre@...com>:
> Reset must be properly assert before deassert.
> This is important if there is an early boot splash screen
> before the kernel start up.
>
> Signed-off-by: Yannick Fertre <yannick.fertre@...com>

Applied on drm-misc-next.
Thansk,
Benjamin

> ---
>  drivers/gpu/drm/stm/ltdc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 96d20c2..8f4606d 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -1130,8 +1130,11 @@ int ltdc_load(struct drm_device *ddev)
>                 }
>         }
>
> -       if (!IS_ERR(rstc))
> +       if (!IS_ERR(rstc)) {
> +               reset_control_assert(rstc);
> +               usleep_range(10, 20);
>                 reset_control_deassert(rstc);
> +       }
>
>         /* Disable interrupts */
>         reg_clear(ldev->regs, LTDC_IER,
> --
> 1.9.1
>