linux-kernel - Re: [PATCH] vsprintf: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Jul 2018 11:49:51 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Petr Mladek <pmladek@...e.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "Tobin C. Harding" <me@...in.cc>, Theodore Ts'o <tytso@....edu>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vsprintf: fix build warning

On Fri, 6 Jul 2018 23:42:13 +0900
Sergey Senozhatsky <sergey.senozhatsky@...il.com> wrote:

> On (07/06/18 15:47), Arnd Bergmann wrote:
> [..]
> > Fixes: bfe80ed3d7c7 ("vsprintf: add command line option debug_boot_weak_hash")  
> 
> Seems like this one is still in linux-next.
> Can we squash this patch and bfe80ed3d7c7?
> 

I prefer not to do squashes unless absolutely necessary. Yes, it is in
next, but even branches pulled into next should try to resist rebasing
(I never rebase my next branch unless there is a real bug that will
break bisecting).

As this is just a warning fix, and not something that should break any
bisect, I say keep it separate. Rebases tend to cause issues.

-- Steve