linux-kernel - RE: [PATCH 1/4] scsi: aacraid: remove AAC_STAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5821f3718a44782a41779fea7e0f6ed@microsemi.com>
Date:   Fri, 6 Jul 2018 16:55:26 +0000
From:   Dave Carroll <david.carroll@...rosemi.com>
To:     Johannes Thumshirn <jthumshirn@...e.de>
CC:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        "Linux Kernel Mailinglist" <linux-kernel@...r.kernel.org>,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
        Raghava Aditya Renukunta 
        <RaghavaAditya.Renukunta@...rosemi.com>
Subject: RE: [PATCH 1/4] scsi: aacraid: remove AAC_STAT_GOOD define

> 
> On Thu, Jul 05, 2018 at 05:42:02PM +0000, Dave Carroll wrote:
> > > Remove the AAC_STAT_GOOD definition and open code it in the places
> > > it was used.
> > >
> > > This will make subsequent refactoring in this area easier.
> > >
> > Please don't ... the definition itself was added to make refactoring easier.
> 
> Well in the end scsi_cmnd::result as we know it currently will go away, so
> splitting up the define is rather crucial for this. I could do it when changing the -
> >result from one integer into 4 u8s but doing it in a separate preparation step
> would be preferable to me and it doesn't hurt accraid at all.
> 

Thanks for the explanation Johannes, the routine is unwieldy already, and it just 
didn't feel right adding back all those lines ... Looking forward to the next step ...

Reviewed-by: Dave Carroll <david.carroll@...rosemi.com>