linux-kernel - Re: [patch 3/7] x86/kvmclock: Decrapify kvm_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3185855-6e63-a07e-629a-0d4afcf3ca6b@redhat.com>
Date:   Fri, 6 Jul 2018 19:38:08 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Radim Krcmar <rkrcmar@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juergen Gross <jgross@...e.com>,
        Pavel Tatashin <pasha.tatashin@...cle.com>,
        steven.sistare@...cle.com, daniel.m.jordan@...cle.com,
        x86@...nel.org, kvm@...r.kernel.org
Subject: Re: [patch 3/7] x86/kvmclock: Decrapify kvm_register_clock()

Decrapification went a bit too far...

On 06/07/2018 18:13, Thomas Gleixner wrote:
> -	int cpu = smp_processor_id();
> -	int low, high, ret;
>  	struct pvclock_vcpu_time_info *src;
> +	int cpu = smp_processor_id();
> +	u64 pa;
>  
>  	if (!hv_clock)
> -		return 0;
> -
> -	src = &hv_clock[cpu].pvti;

... the line above should not have been a "-".  That, or initialize it
in the declaration.  Whoever applies can fix it, no need to repost.
I'll test with the above fix.

Paolo

> -	low = (int)slow_virt_to_phys(src) | 1;
> -	high = ((u64)slow_virt_to_phys(src) >> 32);
> -	ret = native_write_msr_safe(msr_kvm_system_time, low, high);
> -	printk(KERN_INFO "kvm-clock: cpu %d, msr %x:%x, %s\n",
> -	       cpu, high, low, txt);
> +		return;
>  
> -	return ret;
> +	pa = slow_virt_to_phys(src) | 0x01ULL;
> +	wrmsrl(msr_kvm_system_time, pa);
> +	pr_info("kvm-clock: cpu %d, msr %llx, %s\n", cpu, pa, txt);
>  }