linux-kernel - Re: [PATCH] mtd: rawnand: tegra: check bounds of die

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180708235131.348f95f9@xps13>
Date:   Sun, 8 Jul 2018 23:51:31 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Stefan Agner <stefan@...er.ch>
Cc:     boris.brezillon@...tlin.com, dwmw2@...radead.org,
        computersforpeace@...il.com, marek.vasut@...il.com,
        dan.carpenter@...cle.com, dev@...xeye.de, richard@....at,
        marcel@...wiler.com, krzk@...nel.org, digetx@...il.com,
        benjamin.lindqvist@...ian.se, mirza.krak@...il.com,
        gaireg@...reg.de, linux-mtd@...ts.infradead.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: rawnand: tegra: check bounds of die_nr properly

Hi Stefan,

Stefan Agner <stefan@...er.ch> wrote on Wed,  4 Jul 2018 11:13:10 +0200:

> The Tegra driver currently only support a single chip select, hence
> check boundaries accordingly. This fixes a off by one issue catched
> with Smatch:
>     drivers/mtd/nand/raw/tegra_nand.c:476 tegra_nand_select_chip()
>     warn: array off by one? 'nand->cs[die_nr]'
> 
> Also warn in case the stack asks for a chip select we currently do
> not support.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---

Applied to nand/next.

Thanks,
Miquèl