linux-kernel - Re: [PATCH] mtd: rawnand: tegra: check bounds of die

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1531402315.1390.6.camel@toradex.com>
Date:   Thu, 12 Jul 2018 13:31:57 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "stefan@...er.ch" <stefan@...er.ch>,
        "boris.brezillon@...tlin.com" <boris.brezillon@...tlin.com>,
        "miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "dev@...xeye.de" <dev@...xeye.de>,
        "benjamin.lindqvist@...ian.se" <benjamin.lindqvist@...ian.se>,
        "digetx@...il.com" <digetx@...il.com>,
        "mirza.krak@...il.com" <mirza.krak@...il.com>,
        "gaireg@...reg.de" <gaireg@...reg.de>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "computersforpeace@...il.com" <computersforpeace@...il.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "marek.vasut@...il.com" <marek.vasut@...il.com>,
        "richard@....at" <richard@....at>
Subject: Re: [PATCH] mtd: rawnand: tegra: check bounds of die_nr properly

On Wed, 2018-07-04 at 11:13 +0200, Stefan Agner wrote:
> The Tegra driver currently only support a single chip select, hence
> check boundaries accordingly. This fixes a off by one issue catched
> with Smatch:
>     drivers/mtd/nand/raw/tegra_nand.c:476 tegra_nand_select_chip()
>     warn: array off by one? 'nand->cs[die_nr]'
> 
> Also warn in case the stack asks for a chip select we currently do
> not support.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
>  drivers/mtd/nand/raw/tegra_nand.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/tegra_nand.c
> b/drivers/mtd/nand/raw/tegra_nand.c
> index 4daa88d814134..e65ef584df0b9 100644
> --- a/drivers/mtd/nand/raw/tegra_nand.c
> +++ b/drivers/mtd/nand/raw/tegra_nand.c
> @@ -468,7 +468,9 @@ static void tegra_nand_select_chip(struct
> mtd_info *mtd, int die_nr)
>  	struct tegra_nand_chip *nand = to_tegra_chip(chip);
>  	struct tegra_nand_controller *ctrl = to_tegra_ctrl(chip-
> >controller);
>  
> -	if (die_nr < 0 || die_nr > 1) {
> +	WARN_ON(die_nr >= ARRAY_SIZE(nand->cs));

Unfortunately, that has a tiny little issue as die_nr is a signed
integer and ARRAY_SIZE of course is unsigned. While I could have sworn
my shirt off that the compiler would have to promote this to signed
this is not quite what happens and upon deselecting with -1 this
warning gets triggered!

I will send an updated patch explicitly casting the ARRAY_SIZE side to
int as well shortly.

> +
> +	if (die_nr < 0 || die_nr > 0) {
>  		ctrl->cur_cs = -1;
>  		return;
>  	}