[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <10670.1531128774@warthog.procyon.org.uk>
Date: Mon, 09 Jul 2018 10:32:54 +0100
From: David Howells <dhowells@...hat.com>
To: Eric Biggers <ebiggers3@...il.com>
Cc: dhowells@...hat.com, Alexander Viro <viro@...iv.linux.org.uk>,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH 03/18] fs_context: fix detecting full log buffer
Eric Biggers <ebiggers3@...il.com> wrote:
> When 'head' and 'tail' wrap around, 'log->head - log->tail' will be
> something like '4 - 252 = -248', and comparing that directly to the
> array size is wrong. Fix by casting to 'u8'.
I think a better fix is to use CIRC_CNT() or CIRC_SPACE().
David
Powered by blists - more mailing lists