linux-kernel - Re: [PATCH] printk: remove unnecessary kmalloc() from syslog during clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180709114837.zhzwmtcff2y3bl6i@pathway.suse.cz>
Date:   Mon, 9 Jul 2018 13:48:37 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Namit Gupta <gupta.namit@...sung.com>,
        linux-kernel@...r.kernel.org, pankaj.m@...sung.com,
        a.sahrawat@...sung.com, himanshu.m@...sung.com
Subject: Re: [PATCH] printk: remove unnecessary kmalloc() from syslog during
 clear

On Wed 2018-06-27 17:06:41, Petr Mladek wrote:
> On Tue 2018-06-26 10:39:59, Steven Rostedt wrote:
> > This looks fine. For proper history though, what I do in this case,
> > would be to make this into two patches. One with Namit's original
> > patch, and then a second that removes the code duplication (your patch).
> 
> Proposed patch:
> 
> From: Petr Mladek <pmladek@...e.com>
> Date: Wed, 27 Jun 2018 16:37:42 +0200
> Subject: [PATCH] printk: Clean up syslog_print_all()
> 
> syslog_print_all() is called twice. Once with a valid buffer
> and once just to set the indexes.
> 
> Both variants are already handled separately. This patch just
> makes it more obvious. It does not change the existing behavior.

JFYI, I have pushed this separate clean up patch into printk.git,
branch for-4.19.

Best Regards,
Petr