linux-kernel - Re: [PATCH] h8300: remove unnecessary of_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+-psrjcu77x9B6hig96i9Ld2ntimS0ConjWMWCMtupCw@mail.gmail.com>
Date:   Mon, 9 Jul 2018 09:50:27 -0600
From:   Rob Herring <robh@...nel.org>
To:     Yoshinori Sato <ysato@...rs.sourceforge.jp>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "moderated list:H8/300 ARCHITECTURE" 
        <uclinux-h8-devel@...ts.sourceforge.jp>
Subject: Re: [PATCH] h8300: remove unnecessary of_platform_populate call

On Tue, Jun 19, 2018 at 3:40 PM Rob Herring <robh@...nel.org> wrote:
>
> The DT core will call of_platform_populate, so it is not necessary for
> arch specific code to call it unless there are custom match entries,
> auxdata or parent device. Neither of those apply here, so remove the call.
>
> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Cc: uclinux-h8-devel@...ts.sourceforge.jp
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  arch/h8300/kernel/setup.c | 10 ----------
>  1 file changed, 10 deletions(-)

Ping?

>
> diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c
> index a4d0470c10a9..b2b51f75774e 100644
> --- a/arch/h8300/kernel/setup.c
> +++ b/arch/h8300/kernel/setup.c
> @@ -23,7 +23,6 @@
>  #include <linux/init.h>
>  #include <linux/of.h>
>  #include <linux/of_fdt.h>
> -#include <linux/of_platform.h>
>  #include <linux/of_address.h>
>  #include <linux/clk-provider.h>
>  #include <linux/memblock.h>
> @@ -188,15 +187,6 @@ const struct seq_operations cpuinfo_op = {
>         .show   = show_cpuinfo,
>  };
>
> -static int __init device_probe(void)
> -{
> -       of_platform_populate(NULL, NULL, NULL, NULL);
> -
> -       return 0;
> -}
> -
> -device_initcall(device_probe);
> -
>  #if defined(CONFIG_CPU_H8300H)
>  #define get_wait(base, addr) ({                \
>         int baddr;                      \
> --
> 2.17.1
>