linux-kernel - Re: [RFT PATCH 2/4] usb: dwc2: Turn on uframe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANcMJZDYpvwKaNPf_jAvTbLifv2JRcDqo5+JCOkdB7j2A_1gLQ@mail.gmail.com>
Date:   Tue, 10 Jul 2018 16:34:12 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     hminas@...opsys.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jerome Brunet <jbrunet@...libre.com>,
        Zhangfei Gao <zhangfei.gao@...aro.org>,
        Stephen Warren <swarren@...dotorg.org>,
        Bruno Herrera <bruherrera@...il.com>,
        linux-usb@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFT PATCH 2/4] usb: dwc2: Turn on uframe_sched on "his" platforms

On Fri, Jul 6, 2018 at 9:21 AM, Douglas Anderson <dianders@...omium.org> wrote:
> There's no reason to have the uframe scheduler off on dwc2.  Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
>
> The uframe scheduler has been off on HiSilicon since commit
> 37dd9d65cc41 ("usb: dwc2: add support of hi6220").  Since then there
> have been many many improvements, notably the commit 9f9f09b048f5
> ("usb: dwc2: host: Totally redo the microframe scheduler")
>
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Not sure exactly how to exercise this, but in my initial testing with
usb on HiKey, this seems to work ok.

Tested-by: John Stultz <john.stultz@...aro.org>

thanks
-john