linux-kernel - [PATCH] MIPS: generic: fix missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1531333965-7342-1-git-send-email-hofrat@osadl.org>
Date:   Wed, 11 Jul 2018 20:32:45 +0200
From:   Nicholas Mc Guire <hofrat@...dl.org>
To:     Paul Burton <paul.burton@...s.com>
Cc:     Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org, Nicholas Mc Guire <hofrat@...dl.org>
Subject: [PATCH] MIPS: generic: fix missing of_node_put()

 of_find_compatible_node() returns a device_node pointer with refcount
incremented and must be decremented explicitly.  
 As this code is using the result only to check presence of the interrupt 
controller (!NULL) but not actually using the result otherwise the 
refcount can be decremented here immediately again.

Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
Fixes: commit eed0eabd12ef ("MIPS: generic: Introduce generic DT-based board support")
---

Problem located with an experimental coccinelle script

Patch was compiletested with: 32r1_defconfig (implies generic_defconfig)

Patch is against 4.18-rc4 (localversion-next is next-20180711)

 arch/mips/generic/init.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/generic/init.c b/arch/mips/generic/init.c
index 07ec084..a106f81 100644
--- a/arch/mips/generic/init.c
+++ b/arch/mips/generic/init.c
@@ -203,6 +203,7 @@ void __init arch_init_irq(void)
 					    "mti,cpu-interrupt-controller");
 	if (!cpu_has_veic && !intc_node)
 		mips_cpu_irq_init();
+	of_node_put(intc_node);
 
 	irqchip_init();
 }
-- 
2.1.4