linux-kernel - Re: [PATCH] printk: remove unused suppress_message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Jul 2018 10:54:24 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Dave Young <dyoung@...hat.com>,
        Namit Gupta <gupta.namit@...sung.com>,
        Nikitas Angelinas <nikitas.angelinas@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printk: remove unused suppress_message_printing()

On (07/10/18 17:22), Arnd Bergmann wrote:
> Moving the call to suppress_message_printing() into the '#ifdef CONFIG_PRINTK'
> section means that the alternative definition is now unused when PRINTK is
> disabled:
> 
> kernel/printk/printk.c:2033:13: error: 'suppress_message_printing' defined but not used [-Werror=unused-function]
> 
> This removes the stub function.
> 
> Fixes: 375899cddcbb ("printk: make sure to print log on console.")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Arnd, thanks for the patch. I think we got the same report yesterday
(0-day build bot) and Petr have addressed the warning already.

	-ss