linux-kernel - [PATCH] printk: remove unused suppress_message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Jul 2018 17:22:10 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Steven Rostedt <rostedt@...dmis.org>,
        Dave Young <dyoung@...hat.com>,
        Namit Gupta <gupta.namit@...sung.com>,
        Nikitas Angelinas <nikitas.angelinas@...il.com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] printk: remove unused suppress_message_printing()

Moving the call to suppress_message_printing() into the '#ifdef CONFIG_PRINTK'
section means that the alternative definition is now unused when PRINTK is
disabled:

kernel/printk/printk.c:2033:13: error: 'suppress_message_printing' defined but not used [-Werror=unused-function]

This removes the stub function.

Fixes: 375899cddcbb ("printk: make sure to print log on console.")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 kernel/printk/printk.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 4ca0f9bca82c..e015ac4ee367 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2030,8 +2030,6 @@ static void call_console_drivers(const char *ext_text, size_t ext_len,
 				 const char *text, size_t len) {}
 static size_t msg_print_text(const struct printk_log *msg,
 			     bool syslog, char *buf, size_t size) { return 0; }
-static bool suppress_message_printing(int level) { return false; }
-
 #endif /* CONFIG_PRINTK */
 
 #ifdef CONFIG_EARLY_PRINTK
-- 
2.9.0