lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Jul 2018 13:55:10 +0200 From: Greg Kurz <groug@...d.org> To: Matthew Wilcox <willy@...radead.org> Cc: Dominique Martinet <asmadeus@...ewreck.org>, Latchesar Ionkov <lucho@...kov.net>, Eric Van Hensbergen <ericvh@...il.com>, linux-kernel@...r.kernel.org, Ron Minnich <rminnich@...dia.gov>, linux-fsdevel@...r.kernel.org, v9fs-developer@...ts.sourceforge.net Subject: Re: [V9fs-developer] [PATCH v2 1/6] 9p: Fix comment on smp_wmb On Wed, 11 Jul 2018 14:02:20 -0700 Matthew Wilcox <willy@...radead.org> wrote: > The previous comment misled me into thinking the barrier wasn't needed > at all. > > Signed-off-by: Matthew Wilcox <willy@...radead.org> > --- Reviewed-by: Greg Kurz <groug@...d.org> > net/9p/client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/9p/client.c b/net/9p/client.c > index 18c5271910dc..999eceb8af98 100644 > --- a/net/9p/client.c > +++ b/net/9p/client.c > @@ -447,7 +447,7 @@ void p9_client_cb(struct p9_client *c, struct p9_req_t *req, int status) > > /* > * This barrier is needed to make sure any change made to req before > - * the other thread wakes up will indeed be seen by the waiting side. > + * the status change is visible to another thread > */ > smp_wmb(); > req->status = status;
Powered by blists - more mailing lists