linux-kernel - Re: [PATCH] x86/pci: Some buggy virtual functions incorrectly report 1 for intx.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180716221352.GA43385@otc-nc-03>
Date:   Mon, 16 Jul 2018 15:13:52 -0700
From:   "Raj, Ashok" <ashok.raj@...el.com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Joerg Roedel <joro@...tes.org>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Gage Eads <gage.eads@...el.com>,
        Ashok Raj <ashok.raj@...el.com>
Subject: Re: [PATCH] x86/pci: Some buggy virtual functions incorrectly report
 1 for intx.

Hi Alex

On Mon, Jul 16, 2018 at 03:17:57PM -0600, Alex Williamson wrote:
> >  static bool vfio_pci_nointx(struct pci_dev *pdev)
> >  {
> > +	/*
> > +	 * Per PCI, no VF's should have INTx
> > +	 * Simply disable it here
> > +	 */
> > +	if (pdev->is_virtfn)
> > +		return true;
> > +
> >  	switch (pdev->vendor) {
> >  	case PCI_VENDOR_ID_INTEL:
> >  		switch (pdev->device) {
> 
> Nak, this is not what vfio_pci_nointx() is meant for, it's been tried
> before and it was broken:

That seems to make sense. I'll spin a new patch and have that tested
before reposting with the following suggestions.

> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/vfio/pci/vfio_pci.c?id=834814e80268c818f354c8f402e0c6604ed75589
> 
> This would cause *every* VF to print:
> 
> 	dev_info(&pdev->dev, "Masking broken INTx support\n");
> 
> If the device is incapable of generating INTx then it's probably better
> to drop it at vfio_pci_get_irq_count().  Please also note the subject is
> misidentified, this is a "vfio/pci" patch, not an "x86/pci" patch.
> kvm@...r is the official list for vfio patches.  Thanks,
> 
> Alex