linux-kernel - Re: [PATCH] fsinfo: Fix off-by-one bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2c25e3b-4c75-5565-d9ec-7fe53c54d3b5@embeddedor.com>
Date:   Mon, 16 Jul 2018 17:09:52 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     David Howells <dhowells@...hat.com>,
        Alexander Viro <viro@...iv.linux.org.uk>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fsinfo: Fix off-by-one bug

Hi,

Please, drop this patch.

Sorry, I confused fsinfo_attr_statfs with fsinfo_attr__nr.

Thanks
--
Gustavo

On 07/16/2018 05:03 PM, Gustavo A. R. Silva wrote:
> The current code reads one element beyond the end of the
> fsinfo_buffer_sizes array.
> 
> Fixes: 4e635f61dd55 ("fsinfo: Add a system call to allow querying of filesystem information")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  fs/statfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/statfs.c b/fs/statfs.c
> index 3b8e2700..2a28581 100644
> --- a/fs/statfs.c
> +++ b/fs/statfs.c
> @@ -791,7 +791,7 @@ SYSCALL_DEFINE5(fsinfo,
>  		params.Mth = user_params.Mth;
>  	} else {
>  		params.at_flags = 0;
> -		params.request = fsinfo_attr_statfs;
> +		params.request = fsinfo_attr_statfs - 1;
>  		params.Nth = 0;
>  		params.Mth = 0;
>  	}
>