linux-kernel - [PATCH] fsinfo: Fix off-by-one bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180716220306.GA10773@embeddedor.com>
Date:   Mon, 16 Jul 2018 17:03:06 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     David Howells <dhowells@...hat.com>,
        Alexander Viro <viro@...iv.linux.org.uk>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: [PATCH] fsinfo: Fix off-by-one bug

The current code reads one element beyond the end of the
fsinfo_buffer_sizes array.

Fixes: 4e635f61dd55 ("fsinfo: Add a system call to allow querying of filesystem information")
Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
---
 fs/statfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/statfs.c b/fs/statfs.c
index 3b8e2700..2a28581 100644
--- a/fs/statfs.c
+++ b/fs/statfs.c
@@ -791,7 +791,7 @@ SYSCALL_DEFINE5(fsinfo,
 		params.Mth = user_params.Mth;
 	} else {
 		params.at_flags = 0;
-		params.request = fsinfo_attr_statfs;
+		params.request = fsinfo_attr_statfs - 1;
 		params.Nth = 0;
 		params.Mth = 0;
 	}
-- 
2.7.4