linux-kernel - Re: [PATCH v2] base: core: Remove WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2548044.UDzUby0S5K@aspire.rjw.lan>
Date:   Mon, 16 Jul 2018 12:40:08 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>
Cc:     broonie@...nel.org, p.paillet@...com, linux-kernel@...r.kernel.org,
        m.szyprowski@...sung.com,
        Benjamin Gaignard <benjamin.gaignard@...com>
Subject: Re: [PATCH v2] base: core: Remove WARN_ON from link dependencies check

On Monday, July 16, 2018 12:27:35 PM CEST Greg KH wrote:
> On Mon, Jul 16, 2018 at 12:07:20PM +0200, Rafael J. Wysocki wrote:
> > On Monday, July 16, 2018 11:59:52 AM CEST Benjamin Gaignard wrote:
> > > In some cases the link between between customer and supplier
> > > already exist, for example when a device use it parent as supplier [1].
> > 
> > I think this should be "its parent as a supplier".
> > 
> > > Do not warn about already existing dependencies because device_link_add()
> > > take care of this case.
> > 
> > "device_link_add() takes care of"
> > 
> > > [1] https://lkml.org/lkml/2018/7/9/356
> > 
> > There is the Link: tag for links and it is better to not use lkml.org
> > as it is not reliable enough.  You can use lore.kernel.org/lkml/ instead.
> 
> Even better, use:
> 	lkml.kernel.org/r/[message-id]

Where [message-id] is the value of the Message-Id: header (without the
enclosing <>) of the target e-mail message (that you can find by looking
at the raw message).

Thanks,
Rafael