linux-kernel - Re: [PATCH v2] base: core: Remove WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180716102735.GA6269@kroah.com>
Date:   Mon, 16 Jul 2018 12:27:35 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        broonie@...nel.org, p.paillet@...com, linux-kernel@...r.kernel.org,
        m.szyprowski@...sung.com,
        Benjamin Gaignard <benjamin.gaignard@...com>
Subject: Re: [PATCH v2] base: core: Remove WARN_ON from link dependencies
 check

On Mon, Jul 16, 2018 at 12:07:20PM +0200, Rafael J. Wysocki wrote:
> On Monday, July 16, 2018 11:59:52 AM CEST Benjamin Gaignard wrote:
> > In some cases the link between between customer and supplier
> > already exist, for example when a device use it parent as supplier [1].
> 
> I think this should be "its parent as a supplier".
> 
> > Do not warn about already existing dependencies because device_link_add()
> > take care of this case.
> 
> "device_link_add() takes care of"
> 
> > [1] https://lkml.org/lkml/2018/7/9/356
> 
> There is the Link: tag for links and it is better to not use lkml.org
> as it is not reliable enough.  You can use lore.kernel.org/lkml/ instead.

Even better, use:
	lkml.kernel.org/r/[message-id]

thanks,

greg k-h