linux-kernel - Re: [PATCH v6 2/8] KVM: arm/arm64: Re-factor setting the Stage 2 entry to exec on fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee0a72a5-ffa9-6016-80e7-0abc6d65f514@arm.com>
Date:   Mon, 16 Jul 2018 13:46:43 +0100
From:   Suzuki K Poulose <Suzuki.Poulose@....com>
To:     Punit Agrawal <punit.agrawal@....com>, kvmarm@...ts.cs.columbia.edu
Cc:     linux-arm-kernel@...ts.infradead.org, marc.zyngier@....com,
        christoffer.dall@....com, linux-kernel@...r.kernel.org,
        will.deacon@....com
Subject: Re: [PATCH v6 2/8] KVM: arm/arm64: Re-factor setting the Stage 2
 entry to exec on fault

On 16/07/18 12:08, Punit Agrawal wrote:
> Stage 2 fault handler marks a page as executable if it is handling an
> execution fault or if it was a permission fault in which case the
> executable bit needs to be preserved.
> 
> The logic to decide if the page should be marked executable is
> duplicated for PMD and PTE entries. To avoid creating another copy
> when support for PUD hugepages is introduced refactor the code to
> share the checks needed to mark a page table entry as executable.
> 
> Signed-off-by: Punit Agrawal <punit.agrawal@....com>
> Cc: Christoffer Dall <christoffer.dall@....com>
> Cc: Marc Zyngier <marc.zyngier@....com>

Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>