linux-kernel - Re: [PATCH net-next 7/9] net: hns3: Fix for reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b83ce92-a9bd-df76-4566-f5b2e1cce86e@cogentembedded.com>
Date:   Tue, 17 Jul 2018 12:37:06 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Salil Mehta <salil.mehta@...wei.com>, davem@...emloft.net
Cc:     yisen.zhuang@...wei.com, lipeng321@...wei.com,
        mehta.salil@...src.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        Yunsheng Lin <linyunsheng@...wei.com>
Subject: Re: [PATCH net-next 7/9] net: hns3: Fix for reset_level default
 assignment probelm

Hello!

On 7/16/2018 6:36 PM, Salil Mehta wrote:

> From: Yunsheng Lin <linyunsheng@...wei.com>
> 
> handle->reset_level is assigned to HNAE3_NONE_RESET when client is
> initialized, if a tx timeout happens right after initialization,
> then handle->reset_level is not resetted to HNAE3_FUNC_RESET in

    s/resetted/reset/.

> hclge_reset_event, which will cause reset event not properly
> handled problem.
> 
> This patch fixes it by setting handle->reset_level properly when
> client is initialized.
> 
> Fixes: 6d4c3981a8d8 ("net: hns3: Changes to make enet watchdog timeout func common for PF/VF")
> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
> Signed-off-by: Peng Li <lipeng321@...wei.com>
> Signed-off-by: Salil Mehta <salil.mehta@...wei.com>
[...]

MBR, Sergei