linux-kernel - RE: [PATCH net-next 7/9] net: hns3: Fix for reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F4CC6FACFEB3C54C9141D49AD221F7F93BE1BE05@FRAEML521-MBX.china.huawei.com>
Date:   Wed, 18 Jul 2018 07:29:05 +0000
From:   Salil Mehta <salil.mehta@...wei.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "Zhuangyuzeng (Yisen)" <yisen.zhuang@...wei.com>,
        "lipeng (Y)" <lipeng321@...wei.com>,
        "mehta.salil@...src.net" <mehta.salil@...src.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>,
        linyunsheng <linyunsheng@...wei.com>
Subject: RE: [PATCH net-next 7/9] net: hns3: Fix for reset_level default
 assignment probelm

Hi Sergei,

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-
> owner@...r.kernel.org] On Behalf Of Sergei Shtylyov
> Sent: Tuesday, July 17, 2018 10:37 AM
> To: Salil Mehta <salil.mehta@...wei.com>; davem@...emloft.net
> Cc: Zhuangyuzeng (Yisen) <yisen.zhuang@...wei.com>; lipeng (Y)
> <lipeng321@...wei.com>; mehta.salil@...src.net; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org; Linuxarm <linuxarm@...wei.com>;
> linyunsheng <linyunsheng@...wei.com>
> Subject: Re: [PATCH net-next 7/9] net: hns3: Fix for reset_level
> default assignment probelm
> 
> Hello!
> 
> On 7/16/2018 6:36 PM, Salil Mehta wrote:
> 
> > From: Yunsheng Lin <linyunsheng@...wei.com>
> >
> > handle->reset_level is assigned to HNAE3_NONE_RESET when client is
> > initialized, if a tx timeout happens right after initialization,
> > then handle->reset_level is not resetted to HNAE3_FUNC_RESET in
> 
>     s/resetted/reset/.

Thanks for looking through. Will take care in future submissions.

Best regards
Salil
> 
> > hclge_reset_event, which will cause reset event not properly
> > handled problem.
> >
> > This patch fixes it by setting handle->reset_level properly when
> > client is initialized.
> >
> > Fixes: 6d4c3981a8d8 ("net: hns3: Changes to make enet watchdog
> timeout func common for PF/VF")
> > Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
> > Signed-off-by: Peng Li <lipeng321@...wei.com>
> > Signed-off-by: Salil Mehta <salil.mehta@...wei.com>
> [...]
> 
> MBR, Sergei