linux-kernel - Re: [PATCH v2] mtd: rawnand: tegra: check bounds of die

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180718094544.76607c0f@xps13>
Date:   Wed, 18 Jul 2018 09:45:44 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Marcel Ziswiler <marcel@...wiler.com>
Cc:     linux-mtd@...ts.infradead.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, Stefan Agner <stefan@...er.ch>,
        boris.brezillon@...tlin.com, dev@...xeye.de, mirza.krak@...il.com,
        benjamin.lindqvist@...ian.se, krzk@...nel.org,
        marek.vasut@...il.com, richard@....at, digetx@...il.com,
        computersforpeace@...il.com, dwmw2@...radead.org,
        dan.carpenter@...cle.com,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH v2] mtd: rawnand: tegra: check bounds of die_nr properly

Hi Marcel,

Marcel Ziswiler <marcel@...wiler.com> wrote on Tue, 17 Jul 2018
10:46:18 +0200:

> From: Stefan Agner <stefan@...er.ch>
> 
> The Tegra driver currently only support a single chip select, hence
> check boundaries accordingly. This fixes a off by one issue catched
> with Smatch:
>     drivers/mtd/nand/raw/tegra_nand.c:476 tegra_nand_select_chip()
>     warn: array off by one? 'nand->cs[die_nr]'
> 
> Also warn in case the stack asks for a chip select we currently do
> not support.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>

Applied on nand/next in place of the previous one (with my SoB after
yours).

Thanks,
Miquèl