linux-kernel - Re: [PATCH] x86/boot: Fix if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQwEqzbYidax605HD+jQp7Fg45CY72pC2tgKZp3eOf-dA@mail.gmail.com>
Date:   Wed, 18 Jul 2018 14:44:51 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Kees Cook <keescook@...omium.org>, Ingo Molnar <mingo@...hat.com>,
        Dirk Gouders <dirk@...ders.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>, X86 ML <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/boot: Fix if_changed build flip/flop

2018-07-16 7:58 GMT+09:00 Ingo Molnar <mingo@...nel.org>:
>
> * Kees Cook <keescook@...omium.org> wrote:
>
>> The if_changed kbuild function can only be used once per target. If not
>> it will effectively always trigger, flipping back and forth between the
>> two commands getting recorded. Instead, merge the two commands into a
>> single function to get stable build artifacts (i.e. .vmlinux.cmd).
>>
>> Reported-by: Dirk Gouders <dirk@...ders.net>
>
> What actual symptoms does this bug have?
>
> I.e. it would be nice if the changelog started with such an explanation:
>
>   Dirk Gouders reported that .... <bad stuff happens during kernel build> ...
>   and bisected it back to:
>
>     98f78525371b ("x86/boot: Refuse to build with data relocations")
>
>   The root cause of the bug is that the if_changed kbuild function ...
>
> Or something like that.
>
> Thanks,
>
>         Ingo




Anyway, the code diff looks good to me.

Reviewed-by: Masahiro Yamada <yamada.masahiro@...ionext.com>



-- 
Best Regards
Masahiro Yamada