linux-kernel - Re: [PATCH] x86/boot: Fix if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180715225849.GB30102@gmail.com>
Date:   Mon, 16 Jul 2018 00:58:49 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Ingo Molnar <mingo@...hat.com>, Dirk Gouders <dirk@...ders.net>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/boot: Fix if_changed build flip/flop


* Kees Cook <keescook@...omium.org> wrote:

> The if_changed kbuild function can only be used once per target. If not
> it will effectively always trigger, flipping back and forth between the
> two commands getting recorded. Instead, merge the two commands into a
> single function to get stable build artifacts (i.e. .vmlinux.cmd).
> 
> Reported-by: Dirk Gouders <dirk@...ders.net>

What actual symptoms does this bug have?

I.e. it would be nice if the changelog started with such an explanation:

  Dirk Gouders reported that .... <bad stuff happens during kernel build> ... 
  and bisected it back to:

    98f78525371b ("x86/boot: Refuse to build with data relocations")

  The root cause of the bug is that the if_changed kbuild function ...

Or something like that.

Thanks,

	Ingo