linux-kernel - Re: [PATCH v14 20/25] x86/tsc: calibrate tsc only once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82b363bb-de81-0ddf-cb0d-83945eba72f0@cn.fujitsu.com>
Date:   Thu, 19 Jul 2018 14:48:28 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     Pavel Tatashin <pasha.tatashin@...cle.com>,
        <steven.sistare@...cle.com>, <daniel.m.jordan@...cle.com>,
        <linux@...linux.org.uk>, <schwidefsky@...ibm.com>,
        <heiko.carstens@...ibm.com>, <john.stultz@...aro.org>,
        <sboyd@...eaurora.org>, <x86@...nel.org>,
        <linux-kernel@...r.kernel.org>, <mingo@...hat.com>,
        <hpa@...or.com>, <peterz@...radead.org>, <prarit@...hat.com>,
        <feng.tang@...el.com>, <pmladek@...e.com>,
        <gnomes@...rguk.ukuu.org.uk>, <linux-s390@...r.kernel.org>,
        <boris.ostrovsky@...cle.com>, <jgross@...e.com>,
        <pbonzini@...hat.com>
Subject: Re: [PATCH v14 20/25] x86/tsc: calibrate tsc only once

Hi Thomas,

At 07/19/2018 02:25 PM, Thomas Gleixner wrote:
> On Thu, 19 Jul 2018, Dou Liyang wrote:
>> At 07/18/2018 10:22 AM, Pavel Tatashin wrote:
>>> +		(unsigned long)cpu_khz % KHZ);
>>>      	if (cpu_khz != tsc_khz) {
>>>    		pr_info("Detected %lu.%03lu MHz TSC",
>>> -			(unsigned long)tsc_khz / 1000,
>>> -			(unsigned long)tsc_khz % 1000);
>>> +			(unsigned long)tsc_khz / KHZ,
>>> +			(unsigned long)tsc_khz % KHZ);
>>> +	}
>>
>> this curly brackets can be removed
> 
> No. They want to stay, really.
> 
>      https://lkml.kernel.org/r/alpine.DEB.2.20.1701171956290.3645@nanos
> 
> The pr_info() is a multiline statement due to the line breaks.
> 

I see, I’ll keep that in mind.

Thanks,

	dou