linux-kernel - Re: [PATCH -next v4 2/3] media: ov772x: use SCCB regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180719084208.4zdwt4vzcop4hve7@ninjato>
Date:   Thu, 19 Jul 2018 10:42:08 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     jacopo mondi <jacopo@...ndi.org>
Cc:     Akinobu Mita <akinobu.mita@...il.com>, linux-media@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mark Brown <broonie@...nel.org>, Peter Rosin <peda@...ntia.se>,
        Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Mauro Carvalho Chehab <mchehab@...pensource.com>
Subject: Re: [PATCH -next v4 2/3] media: ov772x: use SCCB regmap


> > -static int ov772x_mask_set(struct i2c_client *client, u8  command, u8  mask,
> > -			   u8  set)
> > -{
> > -	s32 val = ov772x_read(client, command);
> > -
> > -	if (val < 0)
> > -		return val;
> > -
> > -	val &= ~mask;
> > -	val |= set & mask;
> > -
> > -	return ov772x_write(client, command, val);
> > -}
> > -
> 
> If I were you I would have kept these functions and wrapped the regmap
> operations there. This is not an issue though if you prefer it this
> way :)

I have suggested this way. It is not a show stopper issue, but I still
like this version better.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)