linux-kernel - Re: [PATCH] cpufreq: qcom-kryo: Silently error out on EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2276619.pSvMmMYWG1@aspire.rjw.lan>
Date:   Thu, 19 Jul 2018 12:45:19 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Niklas Cassel <niklas.cassel@...aro.org>
Cc:     Ilia Lin <ilia.lin@...il.com>, linux-arm-msm@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: qcom-kryo: Silently error out on EPROBE_DEFER

On Wednesday, July 18, 2018 6:44:22 AM CEST Viresh Kumar wrote:
> On 17-07-18, 22:48, Niklas Cassel wrote:
> > If of_nvmem_cell_get() fails due to probe deferal, we shouldn't print an
> > error message. Just be silent in this case.
> > 
> > Signed-off-by: Niklas Cassel <niklas.cassel@...aro.org>
> > ---
> >  drivers/cpufreq/qcom-cpufreq-kryo.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
> > index 29389accf3e9..b8d1e6875f16 100644
> > --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> > +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> > @@ -109,8 +109,9 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> >  	speedbin_nvmem = of_nvmem_cell_get(np, NULL);
> >  	of_node_put(np);
> >  	if (IS_ERR(speedbin_nvmem)) {
> > -		dev_err(cpu_dev, "Could not get nvmem cell: %ld\n",
> > -			PTR_ERR(speedbin_nvmem));
> > +		if (PTR_ERR(speedbin_nvmem) != -EPROBE_DEFER)
> > +			dev_err(cpu_dev, "Could not get nvmem cell: %ld\n",
> > +				PTR_ERR(speedbin_nvmem));
> >  		return PTR_ERR(speedbin_nvmem);
> >  	}
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> 
> 

Applied, thanks!