linux-kernel - Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Jul 2018 08:54:59 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Sebastian Reichel <sre@...nel.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: max77693_charger: fix unintentional
 fall-through

Hi Krzysztof,

On 07/18/2018 01:14 AM, Krzysztof Kozlowski wrote:
> On 17 July 2018 at 23:47, Gustavo A. R. Silva <gustavo@...eddedor.com> wrote:
>> It seems that a *break* is missing in order to avoid a fall-through.
>> Otherwise, the calculation of *data* makes no sense.
>>
>> Addresses-Coverity-ID: 1271172 ("Missing break in switch")
>> Fixes: 87c2d9067893 ("power: max77693: Add charger driver for Maxim 77693")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>> ---
>>  drivers/power/supply/max77693_charger.c | 1 +
>>  1 file changed, 1 insertion(+)
> 
> Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
> 

BTW, I think this also should be tagged for stable.

Thanks
--
Gustavo