linux-kernel - Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180722221717.fgx6nzljnfrw3d5a@earth.universe>
Date:   Mon, 23 Jul 2018 00:17:17 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.co.uk>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: max77693_charger: fix unintentional
 fall-through

Hi,

On Wed, Jul 18, 2018 at 08:14:50AM +0200, Krzysztof Kozlowski wrote:
> On 17 July 2018 at 23:47, Gustavo A. R. Silva <gustavo@...eddedor.com> wrote:
> > It seems that a *break* is missing in order to avoid a fall-through.
> > Otherwise, the calculation of *data* makes no sense.
> >
> > Addresses-Coverity-ID: 1271172 ("Missing break in switch")
> > Fixes: 87c2d9067893 ("power: max77693: Add charger driver for Maxim 77693")
> > Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> > ---
> >  drivers/power/supply/max77693_charger.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>

Thanks, queued to power-supply's fixes branch.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)