linux-kernel - RE: [PATCH] mm: Cleanup in do_shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f98d9b38be1466b8608d5c071aa52ed@AcuMS.aculab.com>
Date:   Thu, 19 Jul 2018 16:21:32 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Kirill Tkhai' <ktkhai@...tuozzo.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "vdavydov.dev@...il.com" <vdavydov.dev@...il.com>,
        "mhocko@...e.com" <mhocko@...e.com>,
        "penguin-kernel@...ove.SAKURA.ne.jp" 
        <penguin-kernel@...ove.SAKURA.ne.jp>,
        "shakeelb@...gle.com" <shakeelb@...gle.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] mm: Cleanup in do_shrink_slab()

From: Kirill Tkhai
> Sent: 19 July 2018 17:05
> 
> Group long variables together to minimize number of occupied lines
> and place all definitions in back Christmas tree order.

Grouping together unrelated variables doesn't really make the code
any more readable.
IMHO One variable per line is usually best.

> Also, simplify expression around batch_size: use all power of C language!

   foo = bar ? : baz;
Is not part of C, it is a gcc extension.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)